Skip to content

Added link to zlib v1.1.3 vulnerability#17156

Merged
Yhg1s merged 1 commit into
python:masterfrom
nosahama:patch-1
Jan 3, 2020
Merged

Added link to zlib v1.1.3 vulnerability#17156
Yhg1s merged 1 commit into
python:masterfrom
nosahama:patch-1

Conversation

@nosahama

Copy link
Copy Markdown
Contributor

This change adds a link to the vulnerability of the zlib v1.1.3 library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nosahama

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher

brandtbucher commented Nov 14, 2019

Copy link
Copy Markdown
Member

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is helpful. One minor comment:

Comment thread Doc/library/zlib.rst Outdated
@nosahama

Copy link
Copy Markdown
Contributor Author

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

I did that already, i don't know what it's not showing up, maybe eventual consistency 😅

@brandtbucher

Copy link
Copy Markdown
Member

Yeah, give it a business day or two. As I understand it, they're processed manually by a human at the PSF.

This change adds a link to the vulnerability of the `zlib v1.1.3` library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.
@brandtbucher

Copy link
Copy Markdown
Member

CC @Yhg1s

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Yhg1s Yhg1s merged commit b789202 into python:master Jan 3, 2020
@nosahama nosahama deleted the patch-1 branch January 4, 2020 20:28
@brandtbucher

Copy link
Copy Markdown
Member

Sorry, I didn't see that this was merged. Congrats on your first CPython contribution @nosahama! 🍾

Looking forward to seeing more from you in the future.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants